Re: [PATCH] perf/x86: fix bug in event constraint end marker macro

[Stephane Eranian]

Ingo,

Ok, I have asked Maria to clean the patch up add more comments and
repost a new version of the
patch. She will repost ASAP.

Thanks.

On Wed, Dec 4, 2013 at 10:03 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> * Stephane Eranian <eranian@xxxxxxxxxx> wrote:
>
>>  #define EVENT_CONSTRAINT_END         \
>> -     EVENT_CONSTRAINT(0, 0, 0)
>> +     { .idxmsk64 = 0,                \
>> +       .code = 0,                    \
>> +       .cmask = 0,                   \
>> +       .weight = -1,                 \
>> +       .overlap = 0,                 \
>> +       .flags = 0,                   \
>> +}
>
> A nit, simply writing:
>
> #define EVENT_CONSTRAINT_END { .weight = -1, }
>
> ... should be enough as initialization to zero is guaranteed for the
> other fields.
>
> Thanks,
>
>         Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/