Re: [PATCH 2/4] perf trace: Fix crash on RHEL6

[Arnaldo Carvalho de Melo]

Em Wed, Dec 04, 2013 at 07:41:40PM -0700, David Ahern escreveu:
> Signed-off-by: David Ahern <dsahern@xxxxxxxxx>

What would make no fields to be present if tp_format is not NULL, i.e.
if the /format file was successfully parsed?

- Arnaldo

> ---
>  tools/perf/builtin-trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index a7aa771a98e6..8f47eaae2f34 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -1455,7 +1455,7 @@ static size_t syscall__scnprintf_args(struct syscall *sc, char *bf, size_t size,
>  {
>  	size_t printed = 0;
>  
> -	if (sc->tp_format != NULL) {
> +	if ((sc->tp_format != NULL) && (sc->tp_format->format.fields != NULL)) {
>  		struct format_field *field;
>  		u8 bit = 1;
>  		struct syscall_arg arg = {
> -- 
> 1.8.3.4 (Apple Git-47)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/