RE: [PATCH] x86/apic: Justification for disabling IO APIC beforeLocal APIC

[Yu, Fenghua]

> From: Ingo Molnar [mailto:mingo.kernel.org@xxxxxxxxx] On Behalf Of Ingo
> Molnar
> Sent: Thursday, December 05, 2013 12:55 AM
> 
> 
> * Fenghua Yu <fenghua.yu@xxxxxxxxx> wrote:
> 
> > From: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> >
> > Since erratum AVR31 in "Intel Atom Processor C2000 Product Family
> > Specification Update" is published, I add a justification comment for
> > disabling IO APIC before Local APIC (commit 522e6646).
> >
> 
> Looks good to me, except that patch titles should start with verbs,
> i.e. something like:
> 
>   x86/apic/doc: Add justification for disabling IO APIC before Local
> APIC
> 
> Which makes for a much more fluid reading of shortlogs etc.
> 
> Unless you sentences without verbs.
>           ^-------------------------------------------like
> 
> ;-)
> 
> Thanks,
> 
> 	Ingo

Thank you very much for your comment, Ingo.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/