Re: [PATCH v2 1/4] introduce for_each_thread() to replace thebuggy while_each_thread()

[Oleg Nesterov]

On 12/04, David Rientjes wrote:
>
> Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

Thanks!

> Minor: should the definitions of thread_{head,node} be annotated with
> __rcu for users of CONFIG_SPARSE_RCU_POINTER?

Perhaps. And perhaps task_struct->tasks. And perhaps we should add
rcu_read_lock_held() || lockdep_is_held(tasklist) || lockdep_is_held(siglock)
into for_each_process/thead.

But lets do this later. At least we should avoid the false positives.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/