Re: [PATCH 2/2] net/fddi: Replace local marco with PCI standardmacro

[Maciej W. Rozycki]

On Thu, 5 Dec 2013, Yijing Wang wrote:

> Replace local marco DFX_BUS_PCI with PCI standard marco
> dev_is_pci().

 Typos above: marco -> macro

> Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx>
> ---
>  drivers/net/fddi/defxx.c |   20 +++++++-------------
>  1 files changed, 7 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c
> index 0b40e1c..0344f71 100644
> --- a/drivers/net/fddi/defxx.c
> +++ b/drivers/net/fddi/defxx.c
> @@ -241,12 +241,6 @@ static char version[] =
>   */
>  #define NEW_SKB_SIZE (PI_RCV_DATA_K_SIZE_MAX+128)
>  
> -#ifdef CONFIG_PCI
> -#define DFX_BUS_PCI(dev) (dev->bus == &pci_bus_type)
> -#else
> -#define DFX_BUS_PCI(dev) 0
> -#endif
> -
>  #ifdef CONFIG_EISA
>  #define DFX_BUS_EISA(dev) (dev->bus == &eisa_bus_type)
>  #else
> @@ -436,7 +430,7 @@ static void dfx_port_read_long(DFX_board_t *bp, int offset, u32 *data)
>  static void dfx_get_bars(struct device *bdev,
>  			 resource_size_t *bar_start, resource_size_t *bar_len)
>  {
> -	int dfx_bus_pci = DFX_BUS_PCI(bdev);
> +	int dfx_bus_pci = dev_is_pci(bdev);
>  	int dfx_bus_eisa = DFX_BUS_EISA(bdev);
>  	int dfx_bus_tc = DFX_BUS_TC(bdev);
>  	int dfx_use_mmio = DFX_MMIO || dfx_bus_tc;

Acked-by: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/