Re: [PATCH RFCv2 0/6] net: phy: Ethernet PHY powerdown optimization

[Florian Fainelli]

2013/12/4 Mugunthan V N <mugunthanvnm@xxxxxx>:
> On Wednesday 04 December 2013 09:14 PM, Sebastian Hesselbarth wrote:
>> This is v2 of an RFC sent earlier [1] to reduce power consumption of network
>> PHYs with link that are either unused or the corresponding netdev is down.
>>
>> In contrast to RFCv1, this now integrates phy_suspend/phy_resume transparent
>> to the netdev drivers. Also, phy_suspend now only suspends the PHY if WOL is
>> disabled. Moreover, the phy state machine calls phy_suspend on entering
>> HALTED state.
>>
>> Again, a branch with RFCv2 applied to v3.13-rc2 can also be found at
>> https://github.com/shesselba/linux-dove.git topic/ethphy-power-rfc-v2
>>
>> [1] http://lwn.net/Articles/574426/
>>
>> Sebastian Hesselbarth (6):
>>   net: mv643xx_eth: properly start/stop phy device
>>   net: phy: marvell: provide genphy suspend/resume
>>   net: phy: provide phy_resume/phy_suspend helpers
>>   net: phy: resume/suspend PHYs on attach/detach
>>   net: phy: suspend unused PHYs on mdio_bus in late_initcall
>>   net: phy: suspend phydev when going to HALTED
>>
>>  drivers/net/ethernet/marvell/mv643xx_eth.c |    4 +++-
>>  drivers/net/phy/marvell.c                  |   22 ++++++++++++++++++++++
>>  drivers/net/phy/mdio_bus.c                 |   25 +++++++++++++++++++++++++
>>  drivers/net/phy/phy.c                      |    6 +++++-
>>  drivers/net/phy/phy_device.c               |   27 +++++++++++++++++++++++++++
>>  include/linux/phy.h                        |    2 ++
>>  6 files changed, 84 insertions(+), 2 deletions(-)
>>
>> ---
>> Cc: David Miller <davem@xxxxxxxxxxxxx>
>> Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>
>> Cc: Mugunthan V N <mugunthanvnm@xxxxxx>
>> Cc: netdev@xxxxxxxxxxxxxxx
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Apart form Sergei's comment the patch series looks good to me.
>
> Acked-by: Mugunthan V N <mugunthanvnm@xxxxxx>

Looks good to me as well:

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Thanks Sebastian!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/