Re: [PATCH 9/9] random: simplify accounting code

[Theodore Ts'o]

On Wed, Nov 13, 2013 at 03:08:41AM -0500, Greg Price wrote:
> +	entropy_count = max_t(int, 0,
> +			      entropy_count - (ibytes << (ENTROPY_SHIFT + 3)));
> +	if (ibytes && cmpxchg(&r->entropy_count, orig, entropy_count) != orig)
> +		goto retry;

I wonder if we would be better dropping the test for ibytes here, so
the above condition reads:

	if (cmpxchg(&r->entropy_count, orig, entropy_count) != orig)
		goto retry;

It further simplifies the code, and it means that if we it turns out
that ibytes is zero (meaning there was no entropy available) but some
additional entropy comes in, we might acutally end up retrying and
successfully grabbing that entropy for the caller.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/