Re: [PATCH] init.h: add missing initcall variants

[Geert Uytterhoeven]

On Sat, Dec 7, 2013 at 4:31 AM, Timur Tabi <timur@xxxxxxxx> wrote:
> On Mon, Dec 2, 2013 at 2:14 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>
>> Add missing initcall variants when building for loadable modules.
>> This fixes this build error on powerpc allmodconfig:
>>
>> drivers/tty/ehv_bytechan.c: error: type defaults to 'int' in declaration of 'console_initcall' [-Werror=implicit-int]
>
> Acked-by: Timur Tabi <timur@xxxxxxxx>
>
> However, I wonder if it makes sense to have a console_initcall in a
> module at all.  Is it possible to load and use a console driver as a
> module?

Of course.

Its use for debugging is limited though, as you obviously won't get output
from it before the module is loaded and the console is registered.

As long as it's e.g. autoloaded from an initramfs, it'll work.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/