Re: [PATCH] mm/zswap.c: add BUG() for default case in zswap_writeback_entry()

[James Hogan]

On 09/12/13 10:11, Chen Gang wrote:
>> Since the metag compiler is stuck on an old version (gcc 4.2.4), which
>> is wrong to warn in this case, and newer versions of gcc don't appear to
>> warn about it anyway (I just checked with gcc 4.7.2 x86_64), I have no
>> objection to this warning remaining in the metag build.
>>
> 
> Do you try "EXTRA_CFLAGS=-W" with gcc 4.7.2? I guess it will report the
> warning too, I don't feel the compiler is smart enough (except it lets
> the long function zswap_get_swap_cache_page really inline)  :-)

EXTRA_CFLAGS=-W on gcc 4.7.2 gives me plenty of pointless unused
parameter warnings when compiling mm/zswap.o, but not the warning you're
trying to silence.

Cheers
James

Attachment: signature.asc
Description: OpenPGP digital signature