Re: [RFC part2 PATCH 2/9] ARM64 / ACPI: Prefill cpu possible/presentmaps and map logical cpu id to APIC id
From: Hanjun Guo
Date: Tue Dec 10 2013 - 10:07:47 EST
On 2013å12æ10æ 20:53, Grant Likely wrote:
On Mon, 2 Dec 2013 23:44:47 +0800, Hanjun Guo <hanjun.guo@xxxxxxxxxx> wrote:
When boot the kernel with MADT, the cpu possible and present maps should be
prefilled for cpu topology and acpi based cpu hot-plug.
The logic cpu id maps to APIC id (GIC id) is also implemented, it is needed
for acpi processor drivers.
Signed-off-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
---
[...]
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index a0c2ca6..1428024 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -420,7 +420,9 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
if (err)
continue;
+#ifndef CONFIG_ACPI
set_cpu_present(cpu, true);
+#endif
max_cpus--;
}
}
This looks wrong. Will this break non-ACPI booting when CONFIG_ACPI is
enabled? The decision on whether or not to run code must be made at
runtime.
Yes, you are right. I'm reworking on this patch now.
Thanks
Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/