Re: [PATCH v3] n_tty: Fix buffer overruns with larger-than-4k pastes

[Peter Hurley]

On 12/10/2013 01:15 AM, Stas Sergeev wrote:
> 09.12.2013 21:10, Peter Hurley ÐÐÑÐÑ:
> > On 12/09/2013 11:26 AM, Stas Sergeev wrote:
> > > 09.12.2013 18:50, Peter Hurley ÐÐÑÐÑ:
> > > >       if (found && read_buf(ldata, eol) == __DISABLED_CHAR) {
> > > >           n--;
> > > >           eof_push = !n && ldata->read_tail != ldata->line_start;
> > > > +        ldata->push = 0;
> > > >       }
> > > Will this work if the last (and only) char written in raw
> > > mode appear to be \0 (__DISABLED_CHAR)?
> >
> > That would have triggered an EOF in older kernels so not a
> > regression.
> I mean the case when icanon is enabled _after_ the
> \0 was written. In an unpatched kernel it will not result
> in an EOL mark, so I don't expect it to trigger EOF.

Right you are, Stas.
I found some other problems as well, so v4 coming.

Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/