Re: [PATCH V3] perf tools: Change the default filenames for perfkvm diff to perf.data.xxx and perf.data.xxx.old

[David Ahern]

On 12/11/13, 9:30 AM, Dongsheng Yang wrote:
> @@ -1001,8 +1002,28 @@ static int data_init(int argc, const char **argv)
>   			use_default = false;
>   		}
>   	} else if (perf_guest) {
> -		defaults[0] = "perf.data.host";
> -		defaults[1] = "perf.data.guest";
> +		char *file_name;
> +		int len, ret;
> +
> +		file_name = (char *)get_filename_for_perf_kvm();
> +		if (!file_name) {
> +			pr_err("Failed to allocate memory for filename\n");
> +			return -ENOMEM;
> +		}
> +

The need for a typecast should tell you something is wrong. Why is 
get_filename_for_perf_kvm returning a const char * when it is allocated 
memory?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/