Re: [PATCH] cgroup: fix fail path in cgroup_load_subsys()

From: Vladimir Davydov
Date: Thu Dec 12 2013 - 13:51:57 EST


On 12/12/2013 10:45 PM, Tejun Heo wrote:
> Hello,
>
> On Thu, Dec 12, 2013 at 10:37:32PM +0400, Vladimir Davydov wrote:
>> If so, I don't mind, but why? cgroup_unload_subsys() should never be
>> called without properly initialized css.
> Hmm.... I think it's generally preferable to reuse normal exit path
> for error handling as much as possible. Plus, the normal cgroup init
> failure path behaves that way. That said, it's more of a preference
> and if you have technical argument, I'd be happy to give in. :)

Got it, will do.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/