Re: [PATCH] gpio: twl4030: fix regression for twl gpio outputs forled pins

[Nishanth Menon]

On 12/13/2013 11:28 AM, Tony Lindgren wrote:
> * Nishanth Menon <nm@xxxxxx> [131213 08:48]:
>> Commit 0b2aa8b (gpio: twl4030: Fix regression for twl gpio output)
>> introduces yet another regression by ignoring the fact that we use twl
>> gpio even for LED. For example, leda (offset 18) is used for USB port2
>> power on beagleboard-xm.
>>
>> The original logic was supposed to setup the TWL4030 GPIO direction
>> if the offset was < TWL4030_GPIO_MAX, and anything greater used
>> twl4030_led_set_value as part of twl_set to setup the LED pin. However,
>> with the commit mentioned above, LEDa pin request will result in fail
>> as the GPIO number for LEDa is equal to TWL4030_GPIO_MAX and USB fails
>> to function on beagleboard-xm. This is reported in the log as:
>> hsusb2_vbus: Failed to request enable GPIO510: -22
>>
>> To fix this, we should handle the fail case of
>> twl4030_set_gpio_direction independent of the offset < TWL4030_GPIO_MAX
>> check.
> 
> Heh again :) Linus has already queued a similar fix, see
> "[PATCH v2 1/1] gpio: twl4030: Fix regression for twl gpio LED output".
> 

Alrite, I admit it, I need a vacation ;).. Sigh..
http://marc.info/?l=linux-gpio&w=2&r=1&s=twl4030&q=t is not good
enough :(..


-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/