Re: [PATCH v3 4/6] pinctrl: Add pinctrl binding for Broadcom CapriSoCs

[Sherman Yin]

On 13-12-12 12:37 PM, Linus Walleij wrote:
> On Wed, Dec 11, 2013 at 7:37 PM, Sherman Yin <syin@xxxxxxxxxxxx> wrote:
>
> > Adds pinctrl driver devicetree binding for Broadcom Capri (BCM281xx) SoCs.
> >
> > Signed-off-by: Sherman Yin <syin@xxxxxxxxxxxx>
> > Reviewed-by: Christian Daudt <bcm@xxxxxxxxxxxxx>
> > Reviewed-by: Matt Porter <matt.porter@xxxxxxxxxx>
> > ---
> > v3: Use generic pin config properties instead of brcm-specific ones.  Clarified
> >      pin types (standard, i2c, hdmi).
> > v2: Use hyphens instead of underscore in DT property names.
>
> Overall this is very nice!

Thanks!

> > +- bias-pull-up:                        Integer. Pull up strength in Ohm:
> > +                                       1: 1.2 kOhm
> > +                                       2: 1.8 kOhm
> > +                                       3: 720 Ohm
> > +                                       4: 2.7 kOhm
> > +                                       5: 831 Ohm
> > +                                       6: 1.08 kOhm
> > +                                       7: 568 Ohm
>
> Please do not use these custom enumerators 1 thru 7.
> Instead say that the argument is given in ohms, so for
> example:
>
> bias-pull-up = <12000>;
>
> Then translate this into the proper enumerator in your
> driver instead.

Ok.  The 3 bits in this enumeration correspond to enabling the 3 pull up 
Rs (1.2k, 1.8k, 2.7k) in parallel, so the enum kind of make sense. But 
sure I can change it to actual ohms and will error out in the driver if 
specified value is not one of the 7.

> No full example provided in the binding! This needs to
> be there for understanding.

Ok Will add some examples.

Thanks,
Sherman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/