Re: [PATCH v2 2/4] pciehp: Use link change notifications forhot-plug and removal

From: Guenter Roeck
Date: Fri Dec 13 2013 - 22:39:42 EST


On Fri, Dec 13, 2013 at 05:58:08PM -0800, Yinghai Lu wrote:
> On Fri, Dec 13, 2013 at 1:14 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> > On Fri, Dec 13, 2013 at 12:04 PM, Rajat Jain <rajatjain@xxxxxxxxxxx> wrote:
> >
> >> Once again: the way I interpret this is:
> >> * Always enable Link events.
> >> * Disable presence events if attention button is present.
> >
> > That sounds like a good plan to me.
>
> How about Diag_Reset from MPT2SAS and others?
> link could up and down
>

Good question. Another question is how this would play together
with AER functions, specifically link_reset and slot_reset.

In this context ... is it possible that the link_reset function from struct
pci_error_handlers is never called, or am I missing something ?

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/