Re: [PATCH] drivers: dca: Mark the function dca_common_get_tag() asstatic in dca-core.c

From: Josh Triplett
Date: Sat Dec 14 2013 - 15:58:22 EST


On Sat, Dec 14, 2013 at 07:14:36PM +0530, Rashika Kheria wrote:
> This patch marks the function dca_common_get_tag() as static in
> dca-core.c because it is not used outside this file.
>
> Thus, it also eliminates the following warning in dca-core.c:
> drivers/dca/dca-core.c:273:4: warning: no previous prototype for âdca_common_get_tagâ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>

Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

> drivers/dca/dca-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dca/dca-core.c b/drivers/dca/dca-core.c
> index 819dfda..9096e59 100644
> --- a/drivers/dca/dca-core.c
> +++ b/drivers/dca/dca-core.c
> @@ -270,7 +270,7 @@ EXPORT_SYMBOL_GPL(dca_remove_requester);
> * @dev - the device that wants dca service
> * @cpu - the cpuid as returned by get_cpu()
> */
> -u8 dca_common_get_tag(struct device *dev, int cpu)
> +static u8 dca_common_get_tag(struct device *dev, int cpu)
> {
> struct dca_provider *dca;
> u8 tag;
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/