RE: [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() asstatic in hv.c

[KY Srinivasan]

> -----Original Message-----
> From: Josh Triplett [mailto:josh@xxxxxxxxxxxxxxxx]
> Sent: Saturday, December 14, 2013 12:57 PM
> To: Rashika Kheria
> Cc: linux-kernel@xxxxxxxxxxxxxxx; KY Srinivasan; Haiyang Zhang;
> devel@xxxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as static
> in hv.c
> 
> On Sat, Dec 14, 2013 at 07:00:06PM +0530, Rashika Kheria wrote:
> > This patch marks the function hv_synic_free_cpu() as static in hv.c
> > because it is not used outside this file.
> >
> > Thus, it also eliminates the following warning in hv.c:
> > drivers/hv/hv.c:304:6: warning: no previous prototype for âhv_synic_free_cpuâ
> [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
> 
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
Thank you.

Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> 
> >  drivers/hv/hv.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> > index f0c5e07..bcb4950 100644
> > --- a/drivers/hv/hv.c
> > +++ b/drivers/hv/hv.c
> > @@ -301,7 +301,7 @@ err:
> >  	return -ENOMEM;
> >  }
> >
> > -void hv_synic_free_cpu(int cpu)
> > +static void hv_synic_free_cpu(int cpu)
> >  {
> >  	kfree(hv_context.event_dpc[cpu]);
> >  	if (hv_context.synic_event_page[cpu])
> > --
> > 1.7.9.5
> >
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i