Re: Regression with suspend resume 5a87182aa21d6d5d306840feab9321818dd3e2a3

From: BjÃrn Mork
Date: Mon Dec 16 2013 - 06:03:11 EST


Viresh Kumar <viresh.kumar@xxxxxxxxxx> writes:
> On 8 December 2013 15:54, Zdenek Kabelac <zkabelac@xxxxxxxxxx> wrote:
>> I'm testing recent 3.13-rc kernel - and I've notice my Lenovo T61 is not
>> able to resume. After bisect I've found commit:
>>
>> 5a87182aa21d6d5d306840feab9321818dd3e2a3
>
> That's my patch, sorry for all the trouble.. Just came back after vacations
> and multiple threads are there with this patch as culprit..
>
> I just tested this patch again on Rafael's linux-next branch and suspend/resume
> and Hibernation are working fine for me on my Thinkpad T420. I don't see any
> issues at all..
>
> scaling_governor: ondemand
> scaling_driver: acpi-cpufreq
>
>> When I just revert this commit with 374b105797c3d4f29c685f3be535c35f5689b30e
>> (3.13-rc3) suspend/resume works again.
>> (I'm using ondemand CPU governor)
>
>> Here is bisect log:
>
>> # bad: [2167e2399dc5e69c62db56d933e9c8cbe107620a] cpufreq: fix garbage
>> kobjects on errors during suspend/resume
>> git bisect bad 2167e2399dc5e69c62db56d933e9c8cbe107620a
>
> I don't read bisect logs well but doesn't you log say that the culprit is
> 2167e2399dc5e69c62db56d933e9c8cbe107620a instead?
>
> I am trying with this patch now, but will take some time for results to be out.

It's both patches in combination. Interesting case, really :-)



BjÃrn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/