[RFC][PATCH 0/3] ION fixups for staging-next
From: John Stultz
Date: Mon Dec 16 2013 - 16:33:40 EST
Since the ION patchset landed in staging-next, there have
been a few build issue reports, and this patchset tries
to address them.
I've marked these as RFC, as I'd really like to get acks
from Colin or someone else on the Android team on these
before merging them.
The first patch is the most trivial.
The second, I not sure if it is better to free the buffer and
continue looking for a smaller order, or if we should just free
the buffer and return NULL.
The last patch is the one I'm least confident of. We could simply
add a depends on RT_MUTEXES to the ION option, but since so few
drivers directly use rt_mutexes, and there's no documentation in
the code that I've noticed as to why the ion_heap uses an rt_mutex,
it probably is best to just convert it to a normal mutex. If this
is wrong, we can instead add the dependency and hopefully some
documentation.
I'd appreciate any thoughts or comments!
thanks
-john
Cc: Colin Cross <ccross@xxxxxxxxxxx>
Cc: Android Kernel Team <kernel-team@xxxxxxxxxxx>
Cc: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
John Stultz (3):
staging: ion: Add HAVE_MEMBLOCK config dependency
staging: ion: Fix possible null pointer dereference
staging: ion: Avoid using rt_mutexes directly.
drivers/staging/android/ion/Kconfig | 1 +
drivers/staging/android/ion/ion_heap.c | 20 ++++++++++----------
drivers/staging/android/ion/ion_system_heap.c | 5 +++++
3 files changed, 16 insertions(+), 10 deletions(-)
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/