Re: [PATCH 1/3] staging: ion: Add HAVE_MEMBLOCK config dependency

[Colin Cross]

Acked-by: Colin Cross <ccross@xxxxxxxxxxx>

On Mon, Dec 16, 2013 at 9:07 PM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> The kbuild test robot reported a build issue w/ ION on m68k:
>
> drivers/staging/android/ion/ion.c: In function 'ion_reserve':
> drivers/staging/android/ion/ion.c:1526:4: error: implicit declaration of function 'memblock_alloc_base' [-Werror=implicit-function-declaration]
> drivers/staging/android/ion/ion.c:1528:11: error: 'MEMBLOCK_ALLOC_ANYWHERE' undeclared (first use in this function)
> drivers/staging/android/ion/ion.c:1528:11: note: each undeclared identifier is reported only once for each function it appears in
> drivers/staging/android/ion/ion.c:1537:4: error: implicit declaration of function 'memblock_reserve' [-Werror=implicit-function-declaration]
>    cc1: some warnings being treated as errors
>
> This is caused by ION using memblock functionality which m68k doesn't support.
>
> This patch adds a HAVE_MEMBLOCK dependency to the ION config.
>
> Cc: Colin Cross <ccross@xxxxxxxxxxx>
> Cc: Android Kernel Team <kernel-team@xxxxxxxxxxx>
> Cc: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> ---
>  drivers/staging/android/ion/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index b95281e..a9a64ea 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -1,5 +1,6 @@
>  menuconfig ION
>         bool "Ion Memory Manager"
> +       depends on HAVE_MEMBLOCK
>         select GENERIC_ALLOCATOR
>         select DMA_SHARED_BUFFER
>         ---help---
> --
> 1.8.3.2
>
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/