Re: [PATCH 2/2] drivers: sfi: Mark functions as static in sfi_core.c

From: Josh Triplett
Date: Tue Dec 17 2013 - 11:35:41 EST


On Tue, Dec 17, 2013 at 06:04:50PM +0530, Rashika Kheria wrote:
> Mark functions sfi_map_table() and sfi_unmap_table() as static in
> sfi_core.c because they are not used outside this file.
>
> This eliminates following warning in sfi_core.c:
> drivers/sfi/sfi_core.c:164:26: warning: no previous prototype for âsfi_map_tableâ [-Wmissing-prototypes]
> drivers/sfi/sfi_core.c:192:6: warning: no previous prototype for âsfi_unmap_tableâ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>

Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

> drivers/sfi/sfi_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c
> index 1e824fb..296db7a 100644
> --- a/drivers/sfi/sfi_core.c
> +++ b/drivers/sfi/sfi_core.c
> @@ -161,7 +161,7 @@ static int sfi_verify_table(struct sfi_table_header *table)
> * Check for common case that we can re-use mapping to SYST,
> * which requires syst_pa, syst_va to be initialized.
> */
> -struct sfi_table_header *sfi_map_table(u64 pa)
> +static struct sfi_table_header *sfi_map_table(u64 pa)
> {
> struct sfi_table_header *th;
> u32 length;
> @@ -189,7 +189,7 @@ struct sfi_table_header *sfi_map_table(u64 pa)
> * Undoes effect of sfi_map_table() by unmapping table
> * if it did not completely fit on same page as SYST.
> */
> -void sfi_unmap_table(struct sfi_table_header *th)
> +static void sfi_unmap_table(struct sfi_table_header *th)
> {
> if (!TABLE_ON_PAGE(syst_va, th, th->len))
> sfi_unmap_memory(th, TABLE_ON_PAGE(th, th, th->len) ?
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/