Re: [PATCH v2] drm/bochs: new driver
From: Gerd Hoffmann
Date: Wed Dec 18 2013 - 02:37:18 EST
On Mi, 2013-12-18 at 11:52 +1000, Dave Airlie wrote:
> On Wed, Dec 18, 2013 at 3:04 AM, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
> > DRM driver for (virtual) vga cards using the bochs dispi
> > interface, such as the qemu standard vga (qemu -vga std).
> >
> > Don't bother supporting anything but 32bpp for now, even
> > though the virtual hardware is able to do that.
>
> Hi Gerd,
>
> just took a quick look over this and it seems in pretty good shape,
> the one worry I have is if you've tested with vesafb loaded, since you
> do some pci_request_regions and fail hard, if vesafb has some of the
> resources this can end up failing the driver load for no good reason.
> I haven't verified there is a problem here its just something we've
> had in the past.
Tested, works. bochs_pci_probe handles it before calling
drm_get_pci_dev, simliar to cirrus.
cheers,
Gerd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/