[RFC PATCH 02/15] ACPICA: Linux: Add configurability for external globals.

From: Lv Zheng
Date: Wed Dec 18 2013 - 04:07:13 EST


OSPMs like Linux trend to include all header files but leave empty inline
stub variables for a feature that is not configured during build.

This patch configures ACPICA external globals out and defines them into
immediates when CONFIG_ACPI is not enabled. Lv Zheng.

Known issues:
1. No possible referencs by !CONFIG_ACPI code
We even don't need to define specific globals into immediates if it is
impossible that there are references for them in !CONFIG_ACPI code.
This patch just adds immediates for all of them from ACPICA's
perspectives.

Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
---
include/acpi/acpixf.h | 11 ++++++++
include/acpi/platform/aclinux.h | 53 +++++++++++++++++++++++++++++++++++++++
2 files changed, 64 insertions(+)

diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
index 76df71d..2fc2094 100644
--- a/include/acpi/acpixf.h
+++ b/include/acpi/acpixf.h
@@ -74,13 +74,24 @@ extern u32 acpi_rsdt_forced;

#else

+#ifndef ACPI_EXTERN
#define ACPI_EXTERN extern
+#endif
+
+#ifndef ACPI_GLOBAL
#define ACPI_GLOBAL(t,a) \
extern t a;
+#endif
+
+#ifndef ACPI_INIT_GLOBAL
#define ACPI_INIT_GLOBAL(t,a,b) \
extern t a;
+#endif
+
+#ifndef ACPI_GLOBAL_FADT
#define ACPI_GLOBAL_FADT \
extern struct acpi_table_fadt acpi_gbl_FADT;
+#endif

#endif

diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h
index 28f4f4d..68cda04 100644
--- a/include/acpi/platform/aclinux.h
+++ b/include/acpi/platform/aclinux.h
@@ -65,6 +65,59 @@
#endif
#include <asm/acpi.h>

+#ifdef CONFIG_ACPI
+
+/*
+ * External acpi_gbl_FADT users will use Revision and Flags to test
+ * features, such code may not well protected by CONFIG_ACPI.
+ */
+#define acpi_get_fadt_revision() (acpi_gbl_FADT.header.revision)
+#define acpi_test_fadt_flags(__flags) (acpi_gbl_FADT.flags & (__flags))
+
+#else /* CONFIG_ACPI */
+
+/* Extarnal globals for __KERNEL__, stubs is needed */
+
+#define ACPI_EXTERN
+#define ACPI_GLOBAL(t,a)
+#define ACPI_INIT_GLOBAL(t,a,b)
+#define ACPI_GLOBAL_FADT
+
+/* Immediates to protect global variables accesses */
+
+#define acpi_current_gpe_count 0
+#define acpi_gbl_trace_flags 0
+#define acpi_gbl_trace_method_name 0
+#define acpi_gbl_system_awake_and_running FALSE
+#define acpi_gbl_reduced_hardware FALSE
+#define acpi_gbl_enable_interpreter_slack FALSE
+#define acpi_gbl_all_methods_serialized FALSE
+#define acpi_gbl_create_osi_method TRUE
+#define acpi_gbl_use_default_register_widths TRUE
+#define acpi_gbl_enable_aml_debug_object FALSE
+#define acpi_gbl_copy_dsdt_locally FALSE
+#define acpi_gbl_truncate_io_addresses FALSE
+#define acpi_gbl_disable_auto_repair FALSE
+#define acpi_gbl_disable_ssdt_table_load FALSE
+#define acpi_gbl_osi_data 0
+#define acpi_dbg_level ACPI_DEBUG_DEFAULT
+#define acpi_dbg_layer ACPI_COMPONENT_DEFAULT
+
+/* Helpers to protect acpi_gbl_FADT accesses */
+
+#define acpi_get_fadt_revision() 0
+#define acpi_test_fadt_flags(__flags) 0
+
+#endif /* CONFIG_ACPI */
+
+#ifndef ACPI_DISASSEMBLER
+
+/* Immediates to protect global variables accesses */
+
+#define acpi_gbl_no_resource_disassembly FALSE
+#define acpi_gbl_ignore_noop_operator FALSE
+#endif
+
/* Host-dependent types and defines for in-kernel ACPICA */

#define ACPI_MACHINE_WIDTH BITS_PER_LONG
--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/