Re: [PATCH 1/4] Create generic early_ioremap() support

[Dave Young]

On 12/17/13 at 01:45pm, Mark Salter wrote:
> On Mon, 2013-12-16 at 09:48 +0800, Dave Young wrote:
> > On 11/27/13 at 09:44pm, Mark Salter wrote:
> > > This patch copies generic bits of x86 early_ioremap() support
> > > into a library for potential use by other architectures.
> > > 
> > > Signed-off-by: Mark Salter <msalter@xxxxxxxxxx>
> > > CC: Arnd Bergmann <arnd@xxxxxxxx>
> > > CC: Ingo Molnar <mingo@xxxxxxxxxx>
> > > CC: linux-arch@xxxxxxxxxxxxxxx
> > > ---
> > >  include/asm-generic/early_ioremap.h |  40 ++++++
> > >  lib/Kconfig                         |   3 +
> > >  lib/Makefile                        |   1 +
> > >  lib/early_ioremap.c                 | 243
> > ++++++++++++++++++++++++++++++++++++
> > 
> > I do not understand why these should go to lib/, I feel it's slightly better
> > move them to mm/
> > 
> > ditto about lib/ioremap.c, ...
> > 
> 
> I hadn't really thought about it. Putting these things in mm doesn't
> sound unreasonable, but lib seems to have become the place for a lot
> generic code which could also belong in mm, net, etc.
> 

IMHO, move subsystem lib code to subsystem core dir looks more reasonable.
lib should be the place for general kernel stuff.

I'm not specific for and object this patch, just give my opinion about the lib/..

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/