Re: [PATCH 05/13] rcu: Fix unraised IPI to timekeeping CPU

From: Frederic Weisbecker
Date: Wed Dec 18 2013 - 10:58:18 EST


On Wed, Dec 18, 2013 at 04:11:58PM +0100, Peter Zijlstra wrote:
> On Wed, Dec 18, 2013 at 03:56:12PM +0100, Frederic Weisbecker wrote:
> > Because scheduler_ipi() conditionally calls irq_enter() and irq_exit()
> > (I wonder if that's a good idea btw, is that here to deal with spurious
> > scheduler IPIs of some sort?)
>
> No its because the traditional scheduler IPI did all the work from the
> interrupt return path -- and like the comment in there says, for many of
> the IPIs that's still true.
>
> So going through the architectures and making all scheduler_ipi callers
> do irq_enter/exit would actually make them slower.

Fair point!

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/