Re: [PATCH 1/2] usb: usbtest: Add timetout to simple_io()

[Felipe Balbi]

On Wed, Dec 18, 2013 at 10:46:03PM +0800, Huang Rui wrote:
> Hi Roger,
> 
> On Wed, Dec 18, 2013 at 03:40:10PM +0530, Roger Quadros wrote:
> > Without a timetout some tests e.g. test_halt() can remain stuck forever.
> > 
> > Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> > Reviewed-by: Felipe Balbi <balbi@xxxxxx>
> > ---
> >  drivers/usb/misc/usbtest.c | 14 +++++++++++---
> >  1 file changed, 11 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
> > index b415282..6294e1b 100644
> > --- a/drivers/usb/misc/usbtest.c
> > +++ b/drivers/usb/misc/usbtest.c
> > @@ -10,6 +10,7 @@
> >  
> >  #include <linux/usb.h>
> >  
> > +#define SIMPLE_IO_TIMEOUT	10000	/* in milliseconds */
> >  
> 
> Only one question, how do you confirm the timeout value?

dude, it's just a timeout. It could be anything, really. 10 seconds is
just large enough value that would allow even the slowest scenarios
(host + device) to complete, while not being so slow that you would
wanna kill yourself after waiting for such a long time ;-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature