Re: [PATCH v3 5/6] ARM: pinctrl: Add Broadcom Capri pinctrl driver

[Sherman Yin]

On 13-12-13 02:22 AM, Mark Brown wrote:
> On Thu, Dec 12, 2013 at 09:54:50PM +0100, Linus Walleij wrote:
>
> > This is a reimplementation of regmap for MMIO.
> > See drivers/base/regmap/regmap-mmio.c
> > Notice how regmap_update_bits() is used throughout the
> > kernel.
>
> > If you want to do this, use regmap.
>
> Or if this is very performance sensitive (which I'd not expect for
> pinctrl) there's a helper in review at the minute which just uses a
> spinlock.

Thanks Mark.  It's not expected to be performance sensitive, so I'll 
probably go with regmap.

Regards,
Sherman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/