Re: [PATCH] tty: an overflow of multiplication indrivers/tty/cyclades.c

From: Greg KH
Date: Wed Dec 18 2013 - 21:41:31 EST


On Wed, Dec 18, 2013 at 09:00:29AM +0800, xqx12 wrote:
> there is an overflow in the code :
> cyz_polling_cycle = (arg * HZ) / 1000,
> the multiplicator arg comes from user, so it may be an overflow if
> arg is a big number. And the value of cyc_polling_cycle will be
> wrong when it is used next time.
>
> Reported-by: Qixue Xiao <xiaoqixue_1@xxxxxxx>
> Suggested-by: Yongjian Xu <xuyongjiande@xxxxxxxxx>
> Suggested-by: Yu Chen <chyyuu@xxxxxxxxx>
> Signed-off-by: Qixue Xiao <xiaoqixue_1@xxxxxxx>

I need a "real" name as the "From:" line here, especially as it doesn't
match any of these lines either :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/