Re: [PATCH] irq-renesas-irqc: simplify irq_set_type() method

[Magnus Damm]

On Thu, Dec 19, 2013 at 5:24 PM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Sat, Dec 14, 2013 at 03:09:31AM +0300, Sergei Shtylyov wrote:
>> Value 0 of the sense  selection field of CONFIG_n register means "disable event
>> detection" and serves in irqc_sense[] for marking the invalid values of the IRQ
>> type (by just omitting initializers). There is no need for INTC_IRQ_SENSE_VALID
>> and hence INTC_IRQ_SENSE() as all field values matching to the  valid IRQ types
>> are non-zero anyway.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>
> Magnus, could you review this?

The patch is IMO only cosmetic so I can't say I care that much. But
since you ask. =)

Acked-by: Magnus Damm <damm@xxxxxxxxxxxxx>

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/