Re: [PATCH] closures: move to lib/

[Kent Overstreet]

On Thu, Dec 19, 2013 at 04:05:16AM -0800, Christoph Hellwig wrote:
> On Wed, Dec 18, 2013 at 05:29:54PM -0800, Kent Overstreet wrote:
> > the closure code was never intended to be bcache specific - hopefully it can be
> > useful elsewhere in the kernel.
> 
> They are not.  They aren't closures in the CS sense,

If you consider the key thing behind CS closures to be spaghetti stacks,
then actually these kind of are.

> and they are an
> ugly mess.  Please work on removing them instead.

That's not really the kind of technical objection one can respond to. If
you think there's a better way of doing this kind of asynchronous stuff,
or a better mechanism already in the kernel (ha!) - please, by all
means, enlighten us.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/