Re: [PATCH] closures: move to lib/

[Tejun Heo]

Hello,

On Thu, Dec 19, 2013 at 04:05:16AM -0800, Christoph Hellwig wrote:
> On Wed, Dec 18, 2013 at 05:29:54PM -0800, Kent Overstreet wrote:
> > the closure code was never intended to be bcache specific - hopefully it can be
> > useful elsewhere in the kernel.
> 
> They are not.  They aren't closures in the CS sense, and they are an
> ugly mess.  Please work on removing them instead.

I pretty much agree with Christoph here.  Compared to all other
generic utilities we have, the proposed mechanism is giant in its
conceptual complexity.  This is a lot worse than semaphores.  I
personally think inclusion of it in the upstream kernel at all was a
bad idea.

 Nacked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/