Re: [PATCH 3/3] drivers: pcmcia: Include appropriate header file in cardbus.c

[Bjorn Helgaas]

On Thu, Dec 19, 2013 at 11:14 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> On Thu, Dec 19, 2013 at 1:36 AM, Rashika Kheria
> <rashika.kheria@xxxxxxxxx> wrote:
>> Include appropriate header file cs_internal.h in cardbus.c because
>> functions cb_alloc() and cb_free() have their prototype declarations in
>> cs_internal.h.
>>
>> This eliminates the following warnings in cardbus.c:
>> drivers/pcmcia/cardbus.c:67:11: warning: no previous prototype for âcb_allocâ [-Wmissing-prototypes]
>> drivers/pcmcia/cardbus.c:105:6: warning: no previous prototype for âcb_freeâ [-Wmissing-prototypes]
>>
>> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
>> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
>
> Applied to my pci/misc branch for v3.14, thanks!

I dropped this for now because it breaks my build:

  CC      drivers/pcmcia/cardbus.o
In file included from drivers/pcmcia/cardbus.c:28:0:
drivers/pcmcia/cs_internal.h:164:9: error: unknown type name âcisdata_tâ
drivers/pcmcia/cs_internal.h:171:9: error: unknown type name âcisdata_tâ
drivers/pcmcia/cs_internal.h:171:25: error: unknown type name âcisparse_tâ
drivers/pcmcia/cs_internal.h:172:28: error: unknown type name âtuple_tâ
drivers/pcmcia/cs_internal.h:173:7: error: unknown type name âcisparse_tâ
drivers/pcmcia/cs_internal.h:177:4: error: unknown type name âtuple_tâ
drivers/pcmcia/cs_internal.h:180:4: error: unknown type name âtuple_tâ
drivers/pcmcia/cs_internal.h:182:52: error: unknown type name âtuple_tâ
make[2]: *** [drivers/pcmcia/cardbus.o] Error 1

My .config is attached.

Bjorn

Attachment: .config
Description: Binary data