Re: [RFCv4 05/11] Documentation: DT: omap-ssi binding documentation
From: Tony Lindgren
Date: Thu Dec 19 2013 - 14:04:09 EST
* Sebastian Reichel <sre@xxxxxxxxxx> [131215 15:30]:
> Create device tree binding documentation for
> OMAP Synchronous Serial Interface (SSI) device.
>
> Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/hsi/omap_ssi.txt | 69 ++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hsi/omap_ssi.txt
>
> diff --git a/Documentation/devicetree/bindings/hsi/omap_ssi.txt b/Documentation/devicetree/bindings/hsi/omap_ssi.txt
> new file mode 100644
> index 0000000..0a9efd8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hsi/omap_ssi.txt
> @@ -0,0 +1,69 @@
> +OMAP SSI controller bindings
> +
> +Required properties:
> +- compatible: Should include "ti,omap3-ssi".
> +- reg-names: Contains the values "sys" and "gdd".
Do you need the reg-names? The order won't change so you can just
document the order in the binding?
> +- reg: Contains a register specifier for each entry in
> + reg-names.
> +- interrupt-names: Contains the value "gdd_mpu".
Maybe interrupt-names are not needed either?
> +- interrupts: Contains interrupt information for each entry in
> + interrupt-names.
> +- ranges Represents the bus address mapping between the main
> + controller node and the child nodes below.
> +- #address-cells Should be set to <1>
> +- #size-cells Should be set to <1>
> +
> +Each port is represented as a sub-node of the ti,omap3-ssi device.
> +
> +Required Port sub-node properties:
> +- compatible: Should be set to the following value
> + ti,omap3-ssi-port (applicable to OMAP34xx devices)
> +- reg-names: Contains the values "rx" and "tx".
Here too?
> +- reg: Contains a register specifier for each entry in
> + reg-names.
> +- interrupt-parent Should be a phandle for the interrupt controller
> +- interrupt-names: Contains the values "mpu_irq0" and "mpu_irq1".
And here?
> +- interrupts: Contains interrupt information for each entry in
> + interrupt-names.
> +- ti,ssi-cawake-gpio: Defines which GPIO pin is used to signify CAWAKE
> + events for the port. This is an optional board-specific
> + property. If it's missing the port will not be
> + enabled.
Hmm this might be just a wake-up GPIO? If so, you should be able to
just set it up as an interrupt and do a request_irq on the pinctrl-single
entry for it.
It might even be one of the already mapped interrupt lines that the code is
remuxing to a GPIO for idle? If so, then you can just use the new binding
for interrupts-extended to handle the wake-up events.
If you post the GPIO number for ti,ssi-cawake-gpio and the interrupt
numbers I can check if there's a need to handle it separately as a GPIO
pin or if it already can be automatically handled for the wake-up events.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/