Re: [PATCH 29/40] mips: Replace __get_cpu_var uses

[Christoph Lameter]

On Thu, 19 Dec 2013, David Daney wrote:

> > 16:07:58.244398747 -0600
> > @@ -43,7 +43,7 @@ DECLARE_PER_CPU(struct mips_fpu_emulator
> >   #define MIPS_FPU_EMU_INC_STATS(M)					\
> >   do {
> > \
> >   	preempt_disable();						\
> > -	__local_inc(&__get_cpu_var(fpuemustats).M);			\
> > +	__this_cpu_inc(fpuemustats.M);					\
> >   	preempt_enable();						\
> >   } while (0)
> >
>
> Something seems to be incorrect in this bit.

Hrmm.. yes this is a local_t so the this_cpu_inc would not work unless
fpuemustats is defined differently.

Use

__local_inc(this_cpu_ptr(fpuemustats.M);

instead until then.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/