RE: [PATCH v3 8/8] drivers: net: Mark functionxenvif_count_frag_slots() as static in netback.c

From: Paul Durrant
Date: Fri Dec 20 2013 - 04:39:35 EST


> -----Original Message-----
> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-
> owner@xxxxxxxxxxxxxxx] On Behalf Of David Miller
> Sent: 19 December 2013 23:53
> To: rashika.kheria@xxxxxxxxx
> Cc: Ian Campbell; Wei Liu; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> josh@xxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 8/8] drivers: net: Mark function
> xenvif_count_frag_slots() as static in netback.c
>
> From: Rashika Kheria <rashika.kheria@xxxxxxxxx>
> Date: Thu, 19 Dec 2013 14:26:47 +0530
>
> > This patch marks the function xenvif_count_frag_slots() in netback.c as
> > static because they are not used outside this file.
> >
> > Thus, it also removes the following warning in xen-netback/netback.c:
> > drivers/net/xen-netback/netback.c:218:14: warning: no previous
> prototype for Êxenvif_count_frag_slotsÊ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
> > Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> This patch doesn't apply cleanly to net-next, please respin.
>

It won't apply to net-next. I removed that function in c/s ca2f09f2b2c6c25047cfc545d057c4edfcfe561c.

Paul
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶Ÿÿà -»+ƒùdš_