Re: spinlock_irqsave() && flags (Was: pm80xx: Spinlock fix)

[Linus Torvalds]

On Mon, Dec 23, 2013 at 10:24 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> However, the code above already has the users. Do you think it makes
> sense to add something like

No. I think it makes sense to put a big warning on any users you find,
and fart in the general direction of any developer who did that broken
pattern.

Because code like that is obviously crap.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/