Re: [PATCH] auxvec.h: account for AT_HWCAP2 in AT_VECTOR_SIZE_BASE

[Linus Torvalds]

Please cc the guilty parties when sending patches like this.

Also, just out of interest, please describe how this bug affected
things. Did we overflow the saved_auxv[] array, or what? Also, how
does this change affect architectures that _don't_ have that
ELF_HWCAP2 thing, ie everything but powerpc?

Acks, people?

           Linus

On Mon, Dec 23, 2013 at 9:49 AM, Ard Biesheuvel
<ard.biesheuvel@xxxxxxxxxx> wrote:
> Commit 2171364d1a92 (powerpc: Add HWCAP2 aux entry) introduced a new
> AT_ auxv entry type AT_HWCAP2 but failed to update AT_VECTOR_SIZE_BASE
> accordingly.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> Fixes: 2171364d1a92 (powerpc: Add HWCAP2 aux entry)
> Cc: stable@xxxxxxxxxxxxxxx
> ---
>
>  include/linux/auxvec.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/auxvec.h b/include/linux/auxvec.h
> index 669fef5..3e0fbe4 100644
> --- a/include/linux/auxvec.h
> +++ b/include/linux/auxvec.h
> @@ -3,6 +3,6 @@
>
>  #include <uapi/linux/auxvec.h>
>
> -#define AT_VECTOR_SIZE_BASE 19 /* NEW_AUX_ENT entries in auxiliary table */
> +#define AT_VECTOR_SIZE_BASE 20 /* NEW_AUX_ENT entries in auxiliary table */
>    /* number of "#define AT_.*" above, minus {AT_NULL, AT_IGNORE, AT_NOTELF} */
>  #endif /* _LINUX_AUXVEC_H */
> --
> 1.8.3.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/