Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

[Sergei Shtylyov]

Hello.

On 24-12-2013 20:35, Joe Perches wrote:

> []
> > > diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
> []
> > > @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net)
> > >
> > >    static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b)
> > >    {
> > > -	return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN);
> > > +	return a->sid == b->sid && ether_addr_equal(a->remote,
> > > +							      b->remote);

> >      If it really doesn't fit insto single line, the continuation line should
> > start right under 'a->remote'.

> Better still might be
>
> 	return a->sid == b->sid &&
> 	       ether_addr_equal(a->remote, b->remote);

   Actually, after the second look, I don't know why the line was broken at all.

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/