Re: [PATCH] lib/vsprintf: add %pT[C012] format specifier

[Andrew Morton]

On Sat, 28 Dec 2013 11:53:25 -0800 Joe Perches <joe@xxxxxxxxxxx> wrote:

> > > #define PRINTK_PID      "\002"
> > > #define PRINTK_TASK_ID  "\003"  /* "comm:pid" */
> > >
> > >         printk(PRINTK_TASK_ID ": hair on fire\n");
> > >
> > > It's certainly compact.  I doubt if there's any existing code which
> > > deliberately prints control chars?
> > 
> > But the rest looks OK to me.
> 
> Tell me again, what's wrong with using p or current?
> 
> printk("%pt", current);

Nothing much.  It's just that all these callsites are generating the
code to pass an argument which the callee already has access to. 
Optimizing that will reduce text size a bit.

There's also the matter of providing a standard and abstracted way of
representing a task, instead of directly accessing its ->comm.  But
that's a separate thing from new printk tokens.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/