Re: [PATCH v2] Staging: tidspbridge: Use hashtable implementation

[Dan Carpenter]

> +	u32 val_size;
> +	DECLARE_HASHTABLE(hash_table, GH_HASH_ORDER);
> +	u32 (*hash)(void *);
> +	bool (*match)(void *, void *);
> +	void (*delete)(void *);

I forgot to say, put the parameter name in the declaration.

+	u32 (*hash)(void *key);
+	bool (*match)(void *key, void *result);
+	void (*delete)(void *key);

I have no idea if those names are correct.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/