Re: [PATCHv9 02/20] thermal: introduce device tree parser

From: Matthew Longnecker
Date: Thu Jan 02 2014 - 12:50:23 EST



I think the platform driver may set governor for the thermal zone,
so how about to add a property named as "governor",
and parse it to tzp->governor_name,
something like:
ret = of_property_read_string(child, "governor", &str);
if (ret == 0)
if (strlen(str) < THERMAL_NAME_LENGTH)
strcpy(tzp->governor_name, str);

Thanks.
Wei.

DT is supposed to describe the hardware, right? The governor isn't hardware -- it's a software control policy. On the other hand, that control policy must be tuned according to the behaviors of the platform hardware otherwise the system will be unstable.

Is it appropriate to be naming the governor in DT? If so, is it equally appropriate to describe any governor-specific parameters in DT (even though they are pure software constructs)?

-Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/