[PATCH 1/7] Make for_each_child_of_node() reference its args whenCONFIG_OF=n

From: David Howells
Date: Fri Jan 03 2014 - 11:07:37 EST


Make for_each_child_of_node() reference its args when CONFIG_OF=n to avoid
warnings like:

drivers/leds/leds-pwm.c:88:22: warning: unused variable 'node' [-Wunused-variable]
struct device_node *node = pdev->dev.of_node;
^

Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
cc: Grant Likely <grant.likely@xxxxxxxxxx>
cc: Rob Herring <robh+dt@xxxxxxxxxx>
cc: devicetree@xxxxxxxxxxxxxxx
---

include/linux/of.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/linux/of.h b/include/linux/of.h
index 276c546980d8..70c64ba17fa5 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -377,8 +377,13 @@ static inline bool of_have_populated_dt(void)
return false;
}

+/* Kill an unused variable warning on a device_node pointer */
+static inline void __of_use_dn(const struct device_node *np)
+{
+}
+
#define for_each_child_of_node(parent, child) \
- while (0)
+ while (__of_use_dn(parent), __of_use_dn(child), 0)

#define for_each_available_child_of_node(parent, child) \
while (0)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/