Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler newline character in the macro

From: Michal Marek
Date: Mon Jan 06 2014 - 04:26:58 EST

On 2014-01-06 06:36, Vineet Gupta wrote:
> Hi Michal,
> On Friday 03 January 2014 06:08 PM, Michal Marek wrote:
>> On 2013-11-21 10:58, Vineet Gupta wrote:
>>> On 11/01/2013 11:15 AM, Vineet Gupta wrote:
>>>> +CC Sam, Tim, Joe, Michal, David
>>>> Guys can you please take a look at this patch and suggest the best way to merge.
>>>> The root cause is some gas ports (including ARC) use ';' for comment (vs. newline)
>>>> More background at
>>> Ping ! Any objections to this. Given that this is exception case, it is simpler
>>> than defining a Kconfig control.
>>> -Vineet
>>>> On 10/29/2013 07:21 AM, Chen Gang wrote:
>>>>> For some assemblers, they use another character as newline in a macro
>>>>> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a
>>>>> macro) instead of ';' for it.
>>>>> Also need notice about code styles ('\t' for each line).
>>>>> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>

> Did you hit reply by mistake - as I can't seem to find any comments...

Oops :). I wanted to ask if this is the final patch that should be
merged, or if there are more known instances of .S code that needs
s/;/ASM_NL/. I did not find any suspects outside arch/ by grepping. If
this is the final patch, Chen, could you please resubmit it? I do not
have the original copy.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at