Re: [PATCH -next] mtd: nuc900_nand: remove redundant return valuecheck of platform_get_resource()

From: Jingoo Han
Date: Tue Jan 07 2014 - 18:59:10 EST


On Tuesday, January 07, 2014 10:39 PM, Wei Yongjun wrote:
>
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>

Reviewed-by: Jingoo Han <jg1.han@xxxxxxxxxxx>

Best regards,
Jingoo Han

> ---
> drivers/mtd/nand/nuc900_nand.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/nuc900_nand.c b/drivers/mtd/nand/nuc900_nand.c
> index 661fd14..9ee09a8 100644
> --- a/drivers/mtd/nand/nuc900_nand.c
> +++ b/drivers/mtd/nand/nuc900_nand.c
> @@ -268,9 +268,6 @@ static int nuc900_nand_probe(struct platform_device *pdev)
> chip->ecc.mode = NAND_ECC_SOFT;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - return -ENXIO;
> -
> nuc900_nand->reg = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(nuc900_nand->reg))
> return PTR_ERR(nuc900_nand->reg);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/