RE: [PATCH 1/1] MTD: UBI: avoid program operation on NOR flashafter erasure interrupted
From: Qi Wang çè (qiwang)
Date: Wed Jan 08 2014 - 20:36:11 EST
Hi Artem:
Do you have any suggestion for my modification?
Other code I think it is ok.
Thanks
-----Original Message-----
From: Qi Wang çè (qiwang)
Sent: Monday, January 06, 2014 1:11 PM
To: 'dedekind1@xxxxxxxxx'
Cc: Adrian Hunter; linux-kernel@xxxxxxxxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx
Subject: RE: [PATCH 1/1] MTD: UBI: avoid program operation on NOR flash after erasure interrupted
>Please, remember that I pushed your patch to a temporary branch, only
>for you to be able to easily pick it. I do not send it upstream.
>As I said, I need to you look at it and confirm that it is all-right.
>And if it is not all-right, correct it.
>This is because I modified it myself.
>So waiting for your response on this.
I checked the code you modified, compile, and run on our platform, it is ok.
+ ubi_err("cannot invalidate PEB %d, write returned %d write returned %d",
+ pnum, err, err);
But I think above code print "write err" twice. so I suggest to change to below:
+ ubi_err("cannot invalidate PEB %d, write returned %d", pnum, err);
I will send you the patch in another email convenient for you to apply patch.
Thanks
--
qiwang
èº{.nÇ+‰·Ÿ®‰†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j¢f£¢·hš‹àz¹®w¥¢¸¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðÃnÆàþY&—