Re: [PATCH/RFC] perf ui/tui: Show column header in hist browser

[Jiri Olsa]

On Thu, Jan 16, 2014 at 09:42:23AM +0900, Namhyung Kim wrote:
> Hi Arnaldo and Jiri,
> 
> On Wed, 15 Jan 2014 11:13:14 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Jan 15, 2014 at 01:10:44PM +0100, Jiri Olsa escreveu:
> >> On Wed, Jan 15, 2014 at 02:08:45PM +0900, Namhyung Kim wrote:
> >> > Add a line for showing column headers like --stdio.
> >> 
> >> https://git.kernel.org/cgit/linux/kernel/git/jolsa/perf.git/commit/?h=perf/lock12&id=1a06d77629cb8870838132688f443b9ca1436026
> >> 
> >> ;-) I'll check your change
> >
> > From a quick view, your change looks better, i.e. being able to toggle
> > the header line.
> >
> > Please let me know what you guys end up agreeing is best.
> 
> Yes, looking at the source, Jiri's version looks much better.  I was
> lazy for sorting column width and supporting a hotkey for toggling. :)
> I just wanted to see how you guys think, so the rfc.

ok, I'll send it out soon with my other changes

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/