Re: [PATCH] Revert "x86: fix 27-rc crash on vsmp due to paravirtduring module load"

[Ingo Molnar]

* Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote:

> This reverts commit 05e12e1c4c09cd35ac9f4e6af1e42b0036375d72.
> 
> The old change from __init --> __init_or_module doesn't make
> sense anymore, given that the arch/x86/kernel/vsmp_64.c code
> is only for non-modular builds.
> 
> As of commit 70511134f61bd6e5eed19f767381f9fb3e762d49
> ("Revert "x86: don't compile vsmp_64 for 32bit") this file
> became obj-y and hence is only for built-in.  That makes
> any "or_module" support redundant.
> 
> We need to distinguish between the two in order to do some
> header cleanups.  This revert starts that process.
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>

I suspect you want to carry this as part of your header cleanups, to 
not have to wait for upstream propagation?

Please fix the title: the original commit was right, but was mooted by 
other changes. That's not a revert but a change that happens to be the 
inverse of an earlier change.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/