Re: [PATCH 11/11] ext4: add cross rename support

[J. Bruce Fields]

On Thu, Jan 16, 2014 at 11:54:06AM +0100, Miklos Szeredi wrote:
> > On Wed, Jan 15, 2014 at 7:23 PM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote:
> > > Do you have a man page update somewhere for the two new flags?
> 
> Here's the updated man page (and attached the patch)

Looks good to me.  Total nits:

>        RENAME_NOREPLACE
>               Don't  overwrite  the  target of the rename.  Return an error if
>               the target would be overwritten.

s/Return an error/Fail with EEXIST/?

(Since it doesn't literally return the error.)

>        ENOENT flags contain RENAME_EXCHANGE and the target of the rename  does
>               not exist

s/the target of the rename/either of the two files/

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/