RE: [PATCH V2 1/1] Drivers: hv: Implement the file copy service
From: KY Srinivasan
Date: Thu Jan 16 2014 - 10:50:24 EST
> -----Original Message-----
> From: Olaf Hering [mailto:olaf@xxxxxxxxx]
> Sent: Thursday, January 16, 2014 3:27 AM
> To: KY Srinivasan
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx
> Subject: Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service
>
> On Tue, Jan 14, K. Y. Srinivasan wrote:
>
> This function should return valid numbers:
>
> > +static ssize_t fcopy_write(struct file *file, const char __user *buf,
> > + size_t count, loff_t *ppos)
> > +{
> > + int error = 0;
> > +
> > + if (count != sizeof(int))
> > + return 0;
>
> Should be an error.
>
> > +
> > + if (copy_from_user(&error, buf, sizeof(int)))
> > + return -EFAULT;
> > +
> > + if (in_hand_shake) {
> > + fcopy_handle_handshake();
> > + return 0;
>
> Should be sizeof(int).
>
> > + }
> > +
> > + /*
> > + * Complete the transaction by forwarding the result
> > + * to the host. But first, cancel the timeout.
> > + */
> > + if (cancel_delayed_work_sync(&fcopy_work))
> > + fcopy_respond_to_host(error);
> > +
> > + return sizeof(int);
> > +}
Olaf,
I will make the changes in the next version of this patch.
Thank you,
K. Y
èº{.nÇ+·®+%Ëlzwm
ébëæìr¸zX§»®w¥{ayºÊÚë,j¢f£¢·hàz¹®w¥¢¸¢·¦j:+v¨wèjØm¶ÿ¾«êçzZ+ùÝj"ú!¶iOæ¬z·vØ^¶m§ÿðÃnÆàþY&